DOCS-2953: Edit mlmodel service from QA #3672
Open
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sguequierre
commented
Nov 13, 2024
sguequierre
commented
- edits infer method, adds from robot, edits get resource name
viambot
added
the
safe to build
sguequierre
commented
Nov 13, 2024
| @@ -206,7 +226,7 @@ Get the `ResourceName` for this instance of the ML model service with the given | |||
| **Example:** | |||
|
|
|||
| ```python {class="line-numbers linkable-line-numbers"} | |||
| my_mlmodel_svc_name = MLModelClient.get_resource_name("my_mlmodel_svc") | |||
| my_mlmodel_svc_name = my_mlmodel.get_resource_name("my_mlmodel_svc") | |||
There was a problem hiding this comment.
created this ticket to fix that in automation
There was a problem hiding this comment.
oh you're right it's a class method, sorry for my misunderstanding. I did look into it originally and became confused thinking this was wrong but now that I look at the python sdk docs again it is at the same level as 'FromRobot', which makes sense as to why it should not be changed. editing ticket now and will fix this here
npentrel
reviewed
Nov 18, 2024
| tensor.Of(tensor.Uint8), | ||
| tensor.WithShape(1, 384, 384, 3), | ||
| tensor.WithBacking(make([]uint8, 1*384*384*3)), | ||
| ), |
sguequierre
commented
Nov 18, 2024
sguequierre
commented
Nov 18, 2024
| tensor.WithShape(1, 384, 384, 3), | ||
| tensor.WithBacking(make([]uint8, 1*384*384*3)), | ||
| ), | ||
| } |
There was a problem hiding this comment.
@npentrel does this look better indentation-wise?
npentrel
reviewed
Nov 22, 2024
npentrel
reviewed
Nov 22, 2024
npentrel
approved these changes
Nov 22, 2024
Co-authored-by: Naomi Pentrel <[email protected]>
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.